Embed native-image configuration file #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastaldi
reviewed
Oct 10, 2024
...main/resources/META-INF/native-image/org.jboss.threads/jboss-threads/native-image.properties
Outdated
Show resolved
Hide resolved
|
Normally I don't accept changes like these on this kind of project. And by "changes like these" I mean changes relating to a specific run time environment for which there are no tests. And by "this kind of project" I mean standalone utility projects. For this reason I no longer accept OSGi patches for example. However, in this particular case, if you add a comment to Thanks! |
zakkak
force-pushed
the
2024-10-10-add-native-image-properties
branch
from
4472521
to
2f1eb15
Compare
See https://www.graalvm.org/jdk21/reference-manual/native-image/overview/BuildConfiguration/#embed-a-configuration-file This way consumers of the maven artifact won't need to manually register the said class for runtime initialization (i.e. quarkusio/quarkus#43798 and similar PRs become redundant)
zakkak
force-pushed
the
2024-10-10-add-native-image-properties
branch
from
2f1eb15
to
ca64fbb
Compare
dmlloyd
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://www.graalvm.org/jdk21/reference-manual/native-image/overview/BuildConfiguration/#embed-a-configuration-file
This way consumers of the maven artifact won't need to manually register the said class for runtime initialization (i.e. quarkusio/quarkus#43798 and similar PRs become redundant)