-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JBTM-3883 use a base64 encoder if required #2281
Conversation
Started testing this pull request with CORE profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK17,label=jnlp-agent/469/ |
Started testing this pull request with CORE profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK11,label=jnlp-agent/469/ |
CORE profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK11,label=jnlp-agent/469/ |
CORE profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK17,label=jnlp-agent/469/ |
Started testing this pull request with CORE profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK17,label=jnlp-agent/470/ |
Started testing this pull request with CORE profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK11,label=jnlp-agent/470/ |
CORE profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK11,label=jnlp-agent/470/ |
CORE profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK17,label=jnlp-agent/470/ |
I've put this on hold while I think through the impact on crash recovery.. |
I've removed the Hold label because Marco, or Manuel, correctly pointed out to me that SHA-224 hashing and base64 encoders are deterministic functions and as such will always produce the same output for a given input string, ie assuming that any particular integration gives us the same string we'll be able to detect records that "belong" to the recovery manager. Note that hashing and slicing, although increasing the probability of collisions, are acceptable because the chances of that happening are extremely low (there was some analysis about probabilities in the associated quarkus issue and PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mike for your PR, LGTM!
https://issues.redhat.com/browse/JBTM-3883
I re-opened JBTM-3883 to add this extra check. I added a comment to the issue and to the test in this PR that explains the details of why the base64 encoder might be needed.
CORE !AS_TESTS !RTS !JACOCO !XTS !QA_JTA !QA_JTS_OPENJDKORB !PERFORMANCE !LRA !DB_TESTS !mysql !db2 !postgres !oracle