Updates, deprecation fixes and GitHub Actions CI setup #21
Conversation
This sets up a workflow with [ComposerRequireChecker](https://github.com/maglnet/ComposerRequireChecker) to make sure all actual dependencies are declared.
This updates tests for PHPUnit v8/v9, and sets up a GHA workflow to run a test matrix for PRs.
This adds a few return type hints where Symfony 5.4 triggers deprecation notices. I don't see the risk of BC breaks since there is no good reason to overwrite the methods affected. Adding types should even be compatible with PHP 7.0.
|
@mpdude : thank you very much for your work. Give me a few day to review it. I should be able to do it by monday. |
|
Awesome! I can't really help with Travis CI, but GitHub actions should run PHPUnit already. Maybe it needs a first time approval by you so that my PRs may trigger runs in your Repo? |
|
|
|
Done. Merged. You were right. It was because github action did not peak up the workflow from the PR to initialize itself. I am going to tag a new major release. Thank you very much |
|
Travis failed in this PR, and I don't know about the results from Scrutinizer. Do you still see value in using these two? |
|
You are right we can remove Scrutinizer. For Travis, it succeeded https://app.travis-ci.com/github/jbouzekri/PhumborBundle when I merged your PR. |
|
Yes, but does it add value over running PHPUnit tests in GitHub Actions? |
|
We can discuss this in #22 . |
Diese neue Major Version enthält keine für uns relevanten Änderungen, vgl. jbouzekri/PhumborBundle#21.
Hi there 👋🏻 ,
this PR provides the results of mpdude#1, mpdude#2 and mpdude#3.
It
Update
This was released as v3.0.0 of this bundle. However, there should be not relevant changes for regular users of this code. As long as you don't extend or replace classes from this bundle, the added return types should not affect you and you should be able to upgrade to v3.0.0 right away.