Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #31

Closed
wants to merge 1 commit into from
Closed

Improvements #31

wants to merge 1 commit into from

Conversation

AlexWayfer
Copy link
Contributor

@AlexWayfer AlexWayfer commented Jan 31, 2018

* Improve `guard-compat` using (https://github.com/guard/guard-compat#migrating-your-api-calls)
* Don't notify about start when no start
* Don't stop Puma if it was started not by Guard
* Remove unused `pry` dependency
* Update versions of dependencies
@AlexWayfer AlexWayfer changed the title * Add pumactl option Improvements Jan 31, 2018
@jc00ke
Copy link
Owner

jc00ke commented Jan 31, 2018

Cool, thank you! This seems like a lot to go into one PR, let alone one commit. Could you at least break apart each bullet point into a separate commit? Ideally there'd be multiple PRs for isolated changes, but I'll concede that that would probably be annoying, so I won't ask.

@AlexWayfer
Copy link
Contributor Author

Oh. I know, but there are many related changes 😅

OK, I'll try.

@AlexWayfer AlexWayfer closed this Jan 31, 2018
@AlexWayfer AlexWayfer mentioned this pull request Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants