renamed the methods and removed the constructors

jcabi · Dec 30, 2015 · 1811316 · 1811316
1 parent 3ee5333
commit 1811316
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 25 deletions.
diff --git a/src/main/java/com/jcabi/dynamodb/maven/plugin/AbstractDynamoMojo.java b/src/main/java/com/jcabi/dynamodb/maven/plugin/AbstractDynamoMojo.java
@@ -127,7 +127,8 @@ protected List<String> args() {
      * @throws MojoFailureException If fails
      */
     protected void environment() throws MojoFailureException {
-        // Intentionally empty!, To be implemented by sub classes.
+        // @checkstyle Intentionally empty!, To be implemented by sub classes!
+        return;
     }
 
     /**

diff --git a/src/main/java/com/jcabi/dynamodb/maven/plugin/AbstractEnviromentMojo.java b/src/main/java/com/jcabi/dynamodb/maven/plugin/AbstractEnviromentMojo.java
@@ -82,18 +82,18 @@ public void environment() throws MojoFailureException {
     }
 
     /**
-     * Dist file.
+     * Location of DynamoDB Local distribution.
      * @return File dist
      */
-    protected File dist() {
+    protected File distdir() {
         return this.dist;
     }
 
     /**
-     * Home file.
+     * Java home directory, where "bin/java" can be executed.
      * @return File home
      */
-    protected File home() {
+    protected File homedir() {
         return this.home;
     }
 }
diff --git a/src/main/java/com/jcabi/dynamodb/maven/plugin/RunMojo.java b/src/main/java/com/jcabi/dynamodb/maven/plugin/RunMojo.java
@@ -39,14 +39,13 @@
 /**
  * Runs DynamoDB Local.
  *
- * @todo #41:30min Let's avoid code duplication between this class and `StartMojo`.
- *  One idea is to create a decorator called `ThreadedMojo` that receives
- *  another mojo in its constructor and, when called, runs it inside a thread.
- *
  * @author Denis N. Antonioli (denisa@sunrun.com)
  * @author Simon Njenga (simtuje@gmail.com)
  * @version $Id$
  * @since 0.8
+ * @todo #41:30min Let's avoid code duplication between this class and `StartMojo`.
+ *  One idea is to create a decorator called `ThreadedMojo` that receives
+ *  another mojo in its constructor and, when called, runs it inside a thread.
  */
 @ToString
 @EqualsAndHashCode(callSuper = false)
@@ -56,18 +55,11 @@
 )
 public final class RunMojo extends AbstractEnviromentMojo {
 
-    /**
-     * Ctor.
-     */
-    public RunMojo() {
-        super();
-    }
-
     @Override
     public void run(final Instances instances) throws MojoFailureException {
         try {
             instances.start(
-                this.dist(), this.tcpPort(), this.home(), this.args()
+                this.distdir(), this.tcpPort(), this.homedir(), this.args()
             );
         } catch (final IOException ex) {
             throw new MojoFailureException(

diff --git a/src/main/java/com/jcabi/dynamodb/maven/plugin/StartMojo.java b/src/main/java/com/jcabi/dynamodb/maven/plugin/StartMojo.java
@@ -52,18 +52,11 @@
 )
 public final class StartMojo extends AbstractEnviromentMojo {
 
-    /**
-     * Ctor.
-     */
-    public StartMojo() {
-        super();
-    }
-
     @Override
     public void run(final Instances instances) throws MojoFailureException {
         try {
             instances.start(
-                this.dist(), this.tcpPort(), this.home(), this.args()
+                this.distdir(), this.tcpPort(), this.homedir(), this.args()
             );
         } catch (final IOException ex) {
             throw new MojoFailureException(