Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#277): Add #deepCopy And #inner() Methods Instead of Node #278

Merged
merged 12 commits into from
Dec 5, 2024
Merged

feat(#277): Add #deepCopy And #inner() Methods Instead of Node #278

merged 12 commits into from
Dec 5, 2024

Conversation

volodya-lombrozo
Copy link
Contributor

In this PR I:

  1. Added two more methods to the XML interface
    1.1. #inner() - returns inner node without copying.
    1.2. #deepCopy() - returns the copy of the inner node.
  2. Optimized XMLDocument constructors to avoid redundant copy operations on XML.

Closes to #277.

@volodya-lombrozo
Copy link
Contributor Author

@yegor256 Could you review these changes, please?

@yegor256 yegor256 merged commit 06f390e into jcabi:master Dec 5, 2024
10 checks passed
@yegor256
Copy link
Member

yegor256 commented Dec 5, 2024

@volodya-lombrozo perfect, many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yegor256 yegor256 yegor256 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@volodya-lombrozo @yegor256