Mumble module nocmake. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joinChannel moves the current user into the given channel identified by channel_id.
Implement joinChannel command
(cherry picked from commit 2617016)
Fix SWAP64 implementation to work on more platforms
…hat other bug before i can test this callback
Change the shell to bash to be compatible with debian base distros which link sh to dash
…en the bug is fixed. I might need to ask upstream on why set_data does not seem to the same output
merging with master
|
There is bash for windows... will it work with that installed? |
|
i currently do not have an windows machine. So i cannot test it. you can take a look what i am using. Technically, I dont need bash and i can use pure python. I just wrote it for clarity and it was quick and dirty https://github.com/joshchang/godot/blob/rdrr_master/modules/mumble/SCsub |
|
Ok thanks |
hungrymonkey
pushed a commit
to hungrymonkey/godot
that referenced
this pull request
Feb 4, 2018
Document the length of a frame in flicks for various NTSC rates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am committing my mumble module. Basic functionality that is enough for a sound demo is here. I still have to add position audio etc.
This commit only have support for joining servers in root. Texting and talking in root channel.
This module as is will not build on windows because there is an embedded bash script in
godot/modules/mumble/SCsub