Don't throw if we can't open browser #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcansdale
force-pushed
the
fixes/11-cross-platform
branch
from
298bd16 to
61c63e0
Compare
Output URLs so user can copy/paste if browse doesn't work.
jcansdale
force-pushed
the
fixes/11-cross-platform
branch
from
61c63e0 to
5301384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output URLs so user can copy/paste if browse doesn't work.
Fixes #13
My Bash for Windows it was throwing
System.ComponentModel.Win32Exception: No such file or directory. This was because I didn't have thexdg-openinstalled (see PowerShell/PowerShell#7198). This PR will make it output the URL and silently fail, allowing the use the copy/paste URL into their Windows browser.