Modify end_tag_regex to allow named arrays #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add CF2021 array member functions - change case for consistency: "metaData" -> "metadata"
When determining if a custom tag uses an end tag, the regex should also allow for the following: thistag["executionmode"] thistag['executionmode'] Currently, the regex only allows for thistag.executionmode to determine the end tag.
…g_regex Modify end_tag_regex to allow named arrays
michaelalandawson
force-pushed
the
master
branch
2 times, most recently
from
9e816f7 to
a3a35e6
Compare
- Allow for the following variable syntax variations: attributes.var attributes["var"] attributes['var']
michaelalandawson
force-pushed
the
master
branch
from
bf6207b to
5659f39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When determining if a custom tag uses an end tag, the regex should also allow for the following:
thistag["executionmode"]
thistag['executionmode']
Currently, the regex only allows for thistag.executionmode to determine the end tag.
The proposed regex was tested with the following variations:
thistag.executionmode == "end"
thistag.executionmode == 'end'
thistag.executionmode eq "end"
thistag.executionmode eq 'end'
thistag.executionmode is "end"
thistag.executionmode is 'end'
thistag["executionmode"] == "end"
thistag["executionmode"] == 'end'
thistag["executionmode"] eq "end"
thistag["executionmode"] eq 'end'
thistag["executionmode"] is "end"
thistag["executionmode"] is 'end'
thistag['executionmode'] == "end"
thistag['executionmode'] == 'end'
thistag['executionmode'] eq "end"
thistag['executionmode'] eq 'end'
thistag['executionmode'] is "end"
thistag['executionmode'] is 'end'
Thank you!