Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ex4 pull request TDD #20

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Ex4 pull request TDD #20

wants to merge 13 commits into from

Conversation

navacohen90
Copy link

No description provided.

navacohen90 added 13 commits May 16, 2016 22:17
@navacohen90
GREEN: correct code for test1 find a person
c829c54
@navacohen90
REFACTOR: add test to check not exists person
e5ee8aa
@navacohen90
RED: Test for find a person in location
ef61078
@navacohen90
GREEN: implement the code for test2 - find a person with location
09a1883
@navacohen90
REFACTOR: change the code for test2- use list of locations
93c7001
@navacohen90
RED: add 2 Tests for check person in location
74f5bc9
@navacohen90
GREEN: change the code for test 2 - use list location and keyword
98ace85
@navacohen90
RED: Test for check map inconsistencies
60ebe1d
@navacohen90
GREEN: implement the code for test check map inconsistencies
590dcdd
@navacohen90
REFACTOR: correct the code for test check map inconsistencies
c529ed0
@navacohen90
RED: Test 2 for check map inconsistencies
9456680
@navacohen90
GREEN: correct the code for test3 - add support to location that not …
804615d 
…in the list
@navacohen90
REFACTOR: refactor for test2 - reuse function find_a_person
6d16902
@navacohen90
Copy link
Author

@hadarp
TDD Mission
Added 3 function.
started with GREEN because the first test was already written.

@navacohen90
Copy link
Author

@hadarp I worked on this ex about 3 hours (I didn't mention it in טופס הגשה so I mention it here)

@ItamarShDev
Copy link
Contributor

👍

@ItamarShDev ItamarShDev closed this Jun 5, 2016
@ItamarShDev ItamarShDev reopened this Jun 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@navacohen90 @ItamarShDev