Service feature #96
Open
Service feature #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s Services to be registered similar to net/rpc package. Add exported functions Client.RegisterService, Client.RegisterServiceName Client.UnregisterService and Client.CallService.
…uires new dependency github.com/mitchellh/mapstructure
Updating the Authorizer and Interceptor interfaces
… 'On' to topics instead of registrating them as procedures. Client.UnregisterServcice unsubscribes from topic. Use locks in the tests to avoid race conditions.
…em as a collection.
…s Services to be registered similar to net/rpc package. Add exported functions Client.RegisterService, Client.RegisterServiceName Client.UnregisterService and Client.CallService.
…uires new dependency github.com/mitchellh/mapstructure
… 'On' to topics instead of registrating them as procedures. Client.UnregisterServcice unsubscribes from topic. Use locks in the tests to avoid race conditions.
…em as a collection.
…e to CamelCase. Use log.Println instead of log.Print in Client.registerService.
|
I hope I did syncing dev with v2 correct. Looks funky with git rebase. |
|
The comment for |
|
That line is wrong. I am sorry, I fixed it. |
|
I run into a problem with mapstructure. You can't customize decoding of structs with methods. It requires hook functions which adds a lot of complexity to turnpike to enable customizing decoding. I prefer the way encoding/json works with methods on the types instead of hook functions. I would like to replace mapstructure with encoding/json. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Service feature similar to net/rpc registration of service methods.
Adds "github.com/mitchellh/mapstructure" as dependency.