Can override notifier implementation with system property

Use -DnotifyWith=growl for example to use growl as notifier implementation whatever configuration set in maven-notifier.properties.
jcgay · Jun 24, 2014 · 9096f44 · 9096f44
1 parent 7df6bc9
commit 9096f44
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 0 deletions.
diff --git a/src/main/java/com/github/jcgay/maven/notifier/AbstractCustomEventSpy.java b/src/main/java/com/github/jcgay/maven/notifier/AbstractCustomEventSpy.java
@@ -13,6 +13,7 @@
 
 public abstract class AbstractCustomEventSpy implements Notifier {
 
+    static final String OVERRIDE_NOTIFIER_IMPLEMENTATION = "notifyWith";
     protected Logger logger;
     protected Configuration configuration;
     protected Stopwatch stopwatch = new Stopwatch();
@@ -39,6 +40,11 @@ public void onFailWithoutProject(List<Throwable> exceptions) {
 
     @Override
     public boolean shouldNotify() {
+        String notifierOverride = System.getProperty(OVERRIDE_NOTIFIER_IMPLEMENTATION);
+        if (notifierOverride != null && !notifierOverride.equals("")) {
+            return getClass().getName().contains(notifierOverride);
+        }
+
         if (getClass().getName().contains(configuration.getImplementation())) {
             return true;
         }

diff --git a/src/test/java/com/github/jcgay/maven/notifier/AbstractCustomEventSpyTest.java b/src/test/java/com/github/jcgay/maven/notifier/AbstractCustomEventSpyTest.java
@@ -3,26 +3,41 @@
 import com.google.common.base.Stopwatch;
 import org.apache.maven.eventspy.EventSpy;
 import org.apache.maven.execution.DefaultMavenExecutionResult;
+import org.testng.annotations.AfterMethod;
 import org.testng.annotations.BeforeMethod;
 import org.testng.annotations.Test;
 
 import java.util.Collections;
 import java.util.Map;
 import java.util.concurrent.TimeUnit;
 
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
 import static org.testng.Assert.assertEquals;
+import static org.testng.Assert.assertFalse;
 import static org.testng.Assert.assertTrue;
 
 public class AbstractCustomEventSpyTest {
 
     private AbstractCustomEventSpy eventSpy;
     private Stopwatch stopwatch;
+    private Configuration configuration;
 
     @BeforeMethod
     public void setUp() throws Exception {
         eventSpy = new AbstractCustomEventSpy() {};
         stopwatch = new Stopwatch(new KnownElapsedTimeTicker(TimeUnit.SECONDS.toNanos(2L)));
         eventSpy.setStopwatch(stopwatch);
+
+        configuration = new Configuration();
+        ConfigurationParser parser = mock(ConfigurationParser.class);
+        when(parser.get()).thenReturn(configuration);
+        eventSpy.setConfiguration(parser);
+    }
+
+    @AfterMethod
+    public void tearDown() throws Exception {
+        System.setProperty(AbstractCustomEventSpy.OVERRIDE_NOTIFIER_IMPLEMENTATION, "");
     }
 
     @Test
@@ -51,4 +66,22 @@ public Map<String, Object> getData() {
 
         assertEquals(stopwatch.elapsedTime(TimeUnit.SECONDS), 2L);
     }
+
+    @Test
+    public void should_override_notifier_implementation_with_system_property() throws Exception {
+
+        System.setProperty(AbstractCustomEventSpy.OVERRIDE_NOTIFIER_IMPLEMENTATION, "Custom");
+        configuration.setImplementation("growl");
+
+        assertTrue(eventSpy.shouldNotify());
+    }
+
+    @Test
+    public void should_not_notify_when_system_property_is_set_and_does_not_match_implementation() throws Exception {
+
+        System.setProperty(AbstractCustomEventSpy.OVERRIDE_NOTIFIER_IMPLEMENTATION, "growl");
+        configuration.setImplementation("Custom");
+
+        assertFalse(eventSpy.shouldNotify());
+    }
 }