-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build notifications are not sent after installing according to instructions in README #20
Comments
I've also confirmed notify-send is installed and working:
|
I don't have the end of the logs but it seems that you have set Possible keys are listed here: https://github.com/jcgay/maven-notifier/wiki#configuration I should probably log a warning when the chosen notifier doesn't exist... |
will try removing that, however, the wiki includes examples of both spellings (with and without a dash) |
The following seems to be working now:
I have this configuration in 3 places: $MAVEN_HOME/lib/ext/maven-notifier.properties, ~/.m2/maven-notifier.properties and .send-notification (all three of which are looked for and reported as missing during debug output, unless they are there...). So... this issue is closeable, but the wiki might need some adjustments? |
Additional data point: the default Maven version 3.3.9 does not work, using the same configuration noted above. It would seem a newer version of Maven is required (3.5.0 worked for me, have the ability to change versions of Maven, would you like for me to step through a few releases to find the minimum version that works? ) |
I spoke too soon, I cannot duplicate the success from earlier, using the same configuration, for either Maven 3.5 or 3.3.9. Looking at the debug log, I think I see the issue:
in trying to run that command manually, I get the following error:
it would seem we need to add some quotation marks to the notify-send message. I will see if I can make this modification myself. If I can figure it out, I'll make a PR. |
While looking into wrapping the build message with quotes (a trivial change) I noticed that the pom.xml limits this code to Java 1.6.... which has been EOL a while. I'm using Java 8. I'm wondering if I just need to give up on this and try something else? |
I managed to get maven-notifier to work, here's a pull request: #21 which addresses this issue. |
You can choose just one configuration file, the recommended one is The output debug command is the array (concatenated with space) passed to In the end, I have not been able to reproduce your error. I'm going to log extra informations to try to understand it. This maven execution gives me a notification with notify-send:
|
I've added logs to get the return code of Could you give it a try and paste the debug log here ? Thanks! |
Feel free to re-open if it's still actual. |
Environment:
debug log:
https://gist.github.com/17d4fe2f4b824eaf24f8a27c917b0869
I've also tried this with the default version of Maven installed by Ubuntu 16.04:
debug log:
https://gist.github.com/hardyoyo/b2ca6ade339d3f48d62bf29b3b942ae8
Any ideas?
The text was updated successfully, but these errors were encountered: