Bugfix/package loading #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for dynamic package loading (googleChartsInit() is not needed anymore). Also allows for easier integration with other parts of the googleCharts API (control structures, formatters etc) down the road.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Joe,
The first commit is to address a problem/bug with googleChartsInit(....) in the use case when the argument is not NULL (loading individual charting packages from within the google charts API).
The second reworks some of the code to use google's chartWrapper (smart enough to know what packages it needs and loads them dynamically) rather than a stand alone chart. This should make googleChartsInit() obsolete.