Defaults to not create prometheus listener #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Listen a TCP port by default can lead to conflict when the controller runs in the host network - `9100` is already used by node exporter. Better tp enable if the exporter is needed than change or remove due to a conflict, which will refuse haproxy to start. Add also some info about the exporter options.
jcmoraisjr
force-pushed
the
jm-prom-empty-port
branch
from
f038f03 to
6d36501
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listen a TCP port by default can lead to conflict when the controller runs in the host network -
9100is already used by node exporter. Better tp enable if the exporter is needed than change or remove due to a conflict, which will refuse haproxy to start.