fix race on failure rate limit queue #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A concurrent read (`q.Run()`) and write (`q.Remove()`) to the q.forget map can panic and crash the controller. The writing was behind a mutex since the `q.Clear()` implementation. Now reading is also behind the same mutex.
jcmoraisjr
force-pushed
the
jm-queue-race
branch
from
1cafdf1 to
22cf444
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A concurrent read (
q.Run()) and write (q.Remove()) to theq.forgetmap can panic and crash the controller. The writing was behind a mutex since theq.Clear()implementation. Now reading is also behind the same mutex.