Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding CPU Map #588

Merged
merged 1 commit into from
May 23, 2020
Merged

Conversation

coldeasy
Copy link

  • Support to entirely disable CPU pinning or have a custom form

@jcmoraisjr
Copy link
Owner

Hi, thanks for supporting this controller! Extra bonus for the docs and the tests.

Following a few remarks:

  • Use a single section ## cpu-map declaring both keys. There are some examples out there.
  • Add both keys in the Configuration Keys table in alphabetical order
  • Use alphabetical order everywhere - doc, defaults, declaration.
  • If possible squash and force push the resulting changes into a single commit

@coldeasy
Copy link
Author

Thanks for the quick feedback @jcmoraisjr - updated based on your comments and rebased off master.

@jcmoraisjr
Copy link
Owner

Thanks! Merging.

@jcmoraisjr jcmoraisjr merged commit 79a3509 into jcmoraisjr:master May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants