Fix backend matches if hostname uses wildcard #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some hostname+path matches happen in the backend to identify if a configuration should or should not be applied. Examples are whitelist, cors, hsts and rewrite path. Frontend matches are correctly using a regex if a wildcard hostname is used. Backends also work but only if all paths share the same configuration, in this case a path ACL is not used. However backends that have distinct path configurations were not properly configuring regex based ACLs - they were trying to match wildcard hostnames with -m begin. This update adds to the backend the same hostname check used in the frontend, which converts begin match to a regex match if a wildcard hostname is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some hostname+path matches happen in the backend to identify if a configuration should or should not be applied. Examples are whitelist, cors, hsts and rewrite path. Frontend matches are correctly using a regex if a wildcard hostname is used. Backends also work but only if all paths share the same configuration, in this case a path ACL is not used. However backends that have distinct path configurations were not properly configuring regex based ACLs - they were trying to match wildcard hostnames with -m begin.
This update adds to the backend the same hostname check used in the frontend, which converts begin match to a regex match if a wildcard hostname is used.