Ensure that configured global ConfigMap exists #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Launch is actually copying the global configmap name from the command-line straight to the lister without checking its existence. The lister will watch configmap events and will only wake up if the name matches with the one provided in the command-line, so currently a mistyped name is silently ignored. From now the configmap name is checked in the bootstrap process and will crash if not found or if the controller doesn't have permission to read it. This should be merged as far as v0.10, but v0.12 and older should only log error instead, due to preserve backward compatibility with the current behavior.
|
Thank you for the quick turnaround on this one! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch is actually copying the global configmap name from the command-line straight to the lister without checking its existence. The lister will watch configmap events and will only wake up if the name matches with the one provided in the command-line, so currently a mistyped name is silently ignored.
From now the configmap name is checked in the bootstrap process and will crash if not found or if the controller doesn't have permission to read it.
This should be merged as far as v0.10, but v0.12 and older should only log error instead, due to preserve backward compatibility with the current behavior.