Add log of reload error on every reconciliation #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the visibility of a configuration issue. Currently only reload attempts would lead to a log error if the current state builds an invalid configuration file. This change adds an error log on every reconciliation, being dynamic or not, informing the timestamp when the configuration was broken for the first time, if the configuration is in fact broken. A broken configuration leads to new state not being correctly applied, and should also promote an outage if the controller or haproxy crashes, or the controller restarts.
mkubaczyk
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the visibility of a configuration issue. Currently only reload attempts would lead to a log error if the current state builds an invalid configuration file. This change adds an error log on every reconciliation, being dynamic or not, informing the timestamp when the configuration was broken for the first time, if the configuration is in fact broken. A broken configuration leads to new state not being correctly applied, and should also promote an outage if the controller or haproxy crashes, or the controller restarts.