Check by default if gateway api crds are installed #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change default value of `--watch-gateway` command-line option to true, so try to listen to gateway API CRDs by default. This new implementation will skip registration of listers and informers if the crds are not installed in the server, contrary to v0.13 which would always try to register them. There is a backward incompatibility, a v0.13 controller that doesn't declare the command-line option would ignore gateway api resources, while v0.14 would find and configure them by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change default value of
--watch-gatewaycommand-line option to true, so try to listen to gateway API CRDs by default. This new implementation will skip registration of listers and informers if the crds are not installed in the server, contrary to v0.13 which would always try to register them.There is a backward incompatibility, a v0.13 controller that doesn't declare the command-line option would ignore gateway api resources, while v0.14 would find and configure them by default.