Fixes to C# branch: unit tests and code generation #76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I'm glad to have found this project, this parser generator is awesome!
I wanted to contribute some improvements, in the hope that the C# variant gets finalized and merged into the main branch - it would be amazing to have C# coverage in addition to the other languages.
I see that there was an old PR#70, which got merged into
c-sharp
branch, but some of the desiderata were still waiting to be addressed. This pull request addresses the following:Regarding .NET - these changes are only relevant for people running
make
and unit tests. I upgraded project and test files, because Core 6/8 are the only ones with current long-term support - older versions of .NET are now past their end-of-life date, and running them will be increasingly difficult.However, this is only for testing. The generated C# code is highly backwards-compatible, and I would expect it to work with .NET going back a decade or more.
Testing:
I ran unit tests on Ubuntu (x86) with dotnet sdks 6.0 and 8.0:
I hope this is useful in bringing this branch closer to merging with main - and please let me know if I can help with C# support!