Support OTP-21's unicode-only constraints #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions start being available in OTP-20, so to get rid of warnings, a conditional compilation flag is set there. The cspan function has no direct equivalent, but can be worked around. Likely heavier work would be required around its usage where strings are not handled as lists, but only through 'string' functions. However this will still cover most cases and get rid of compile-time warnings for now.
|
Thanks! |
|
Thanks. Let me know when this is on hex; I'm updating dependencies of rebar3 ahead of time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions start being available in OTP-20, so to get rid of warnings, a
conditional compilation flag is set there.
The cspan function has no direct equivalent, but can be worked around.
Likely heavier work would be required around its usage where strings are
not handled as lists, but only through 'string' functions. However this
will still cover most cases and get rid of compile-time warnings for
now.