Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update selenium-chromedriver gem and fix missing turbo frame element javascript error #402

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Update selenium-chromedriver gem and fix missing turbo frame element javascript error #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
10177fb
Update Gemfile
jcowhigjr Dec 3, 2023
f4dc498
update
jcowhigjr Dec 3, 2023
9189d96
note to remove chromedriver locally for tests to pass
jcowhigjr Dec 19, 2023
f3cdfdf
fix found by consulting https://github.com/hotwired/turbo/pull/863
jcowhigjr Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Brewfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,6 @@ brew 'lefthook'
brew 'ngrok'
# brew 'solargraph'
# brew 'solargrpah-rails'

# chromedriver not required anymore
# brew uninstall chromedriver
1 change: 0 additions & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ group :test do

# Easy installation and use of web drivers to run system tests with browsers
gem 'matrix'
gem 'webdrivers'

# gem 'minitest-colorize'
gem 'cuprite'
Expand Down
5 changes: 0 additions & 5 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,10 +454,6 @@ GEM
activemodel (>= 6.0.0)
bindex (>= 0.4.0)
railties (>= 6.0.0)
webdrivers (5.2.0)
nokogiri (~> 1.6)
rubyzip (>= 1.3.0)
selenium-webdriver (~> 4.0)
webrick (1.7.0)
websocket (1.2.10)
websocket-driver (0.7.6)
Expand Down Expand Up @@ -523,7 +519,6 @@ DEPENDENCIES
turbo-rails (~> 1.5.0)
tzinfo-data
web-console
webdrivers

RUBY VERSION
ruby 3.2.2p53
Expand Down
2 changes: 1 addition & 1 deletion app/views/reviews/_show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<%= link_to t('.edit-this-revie-0'), edit_user_review_path(current_user, review), class: 'btn-small' %>
</div>
<div class="col s6">
<%= link_to t('.delete-this-rev'), user_review_path(current_user, review), class: 'btn-small', data: { turbo_method: :delete } %>
<%= link_to t('.delete-this-rev'), user_review_path(current_user, review), class: 'btn-small', data: { turbo_method: :delete, turbo_frame: '_top' } %>
</div>
</div>
<% end %>
Expand Down
1 change: 1 addition & 0 deletions test/system/coffeeshops_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ class CoffeeshopsTest < ApplicationSystemTestCase
assert_text('"this place is bad"', count: 1)
assert_selector('#review_rating', text: '★☆☆☆☆')
assert_current_path %r{^/coffeeshops/\d{1,9}}

click_on 'Delete', match: :first

assert_current_path %r{^/coffeeshops/\d{1,9}}
Expand Down
Loading