omit_defaults
supports specifying tuple
/frozenset
default values via default_factory
#653
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
omit_defaults
would only detecttuple
/frozenset
fields containing default values if the default was specified by value.We now also support if these types are specified via
default_factory
(all 3 cases above now properly work withomit_defaults=True
).Note that since
tuple
andfrozenset
values are immutable there's no real reason to preferdefault_factory
for defaults of these types.Fixes #652.