Draft: feat: allow converting subclasses of tagged structs #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is a very rough draft, opening to see if @jcrist will be open for this feature/approach.
It addresses #656 and my own #541 - allowing to decode data representing a tagged struct subclass in place of the super class.
This feature prevents me from switching to msgspec in my ast library, but should be generally very usable for any tree-like structure/messages.
As of time of writing, in order for this PR to be complete, at least the following has to be handled:
allow_tagged_struct_subtypeskwarg into json, msg pack decodersallow_tagged_struct_subtypes, so it will not honor the flag after decoder (type node) is cached for the first time