chore: 3.13 support #703
Closed
chore: 3.13 support #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
LecrisUT
reviewed
Jun 15, 2024
| @@ -80,7 +83,7 @@ jobs: | |||
| env: | |||
| CIBW_TEST_REQUIRES: "pytest msgpack pyyaml tomli tomli_w" | |||
| CIBW_TEST_COMMAND: "pytest {project}/tests" | |||
| CIBW_BUILD: "cp38-* cp39-* cp310-* cp311-* cp312-*" | |||
| CIBW_BUILD: "cp38-* cp39-* cp310-* cp311-* cp312-* cp13-*" | |||
There was a problem hiding this comment.
Usually pypa/cibuildwheel minor version takes care of adding and removing EOL and new python versions. I think there is some handling for pre-release but don't remember how.
Could consider moving these to the pyproject.toml to make it more easily reproducible and removing the explicit CIBW_BUILD?
(Not in this PR, but a subsequent one when python 3.13 is working)
mgorny
reviewed
Jul 12, 2024
| #if PY313_PLUS | ||
| // Python 3.13 adds an extra argument to control whether to throw an error on overflow. | ||
| // This happens by default in older versions, so simply match the behavior. | ||
| out = _PyLong_AsByteArray((PyLongObject *)int128, buf, 16, 0, 0, 0, 1); |
There was a problem hiding this comment.
…and passing one argument too many in both branches.
|
@mgorny @max-muoto I've put up #711 and I can confirm wheels can be built and tests pass on Python 3.13 |
This was referenced Aug 18, 2024
|
Closing in favor of #711, thanks @edgarrmondragon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues detailed in #698