Use Option<String> for address's #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfconrad
force-pushed
the
pr_address_as_option_string
branch
from
1cb5bfe
to
ccd45f0
Compare
cfconrad
force-pushed
the
pr_address_as_option_string
branch
from
ccd45f0
to
c082815
Compare
jcronenberg
approved these changes
Jan 16, 2024
jcronenberg
added a commit
that referenced
this pull request
Nov 7, 2024
Use Option<String> for address's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With agama-project#983 was merged, we can simplify our code.