Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kleptography: UI Changes #40

Open
gknocke opened this issue Jun 11, 2012 · 2 comments
Open

Kleptography: UI Changes #40

gknocke opened this issue Jun 11, 2012 · 2 comments
Labels
Area:UI+UX-Logic Everything related to SWT / general RCP UI Phase:Backlog Let's get to inbox zero Type:New-Feature

Comments

@gknocke
Copy link
Member

gknocke commented Jun 11, 2012

1. A reset possibility is missing
2. Most text areas have the same height as a regular text field. So then,
3. In the box "Standard cryptosystem values" there are some buttons optional ("Gernerate primes P and Q instead of filling out these fields manually) and some represent different decisions, regarding the next steps (Gernerate all at once or generate step by step). This setting is not user-friendly. I suggest to add a "Step by step" button next to "Generate all at once". This button then enables the "Gernerate primes P and Q" button.
4. Method "Attack 1": After "Safe public key and ciphertext" is done, all options up to "Generate P and Q" should be disabled in order to force the user to choose a new prime.
5. Method "Attack 1": The tab "Attacking fixed P" has a quite different setting. The buttons are seperated from the values and the description changes its position from right to left. The layouts should be at least similar.
6. Method "Attack 1" --> Tab "Attacking fixed P": The used buttons should be disabled.
7. "Back to Key Generation and Encryption" is not a part of the computation steps and therefore there has to be at least a newline between "Back to Key Generation and Encryption" and "Decrypt ciphertexts".
8. "Attack 2" and "Attack 3" have no visualization and these attacks are not performed. I think these two options should be removed.

@simlei
Copy link
Member

simlei commented Oct 11, 2017

Needs review, still seems to be open.

  1. is invalid, we have a reset possibility now.

@grthor
Copy link
Member

grthor commented Sep 19, 2018

I looked at the plugin. Some points have already been settled.

  1. There is a reset option in the upper right corner.
  2. I do not know what should be meant. The text boxes have the default height.
  3. This is fixed, the fields for P and Q can be entered directly manually.
  4. This point is still open.
  5. The explanation in the Attack tabs is now on the right.
  6. This point is still open.
  7. A separator between the buttons has been added.
  8. Can I confirm, but would still leave it in the plugin.

Thus only points 4 and 6 would be open.

grthor pushed a commit to grthor/crypto that referenced this issue Sep 19, 2018
- Replaced the hard Borders of the composites in the attack tabs with
groups that have a smoother border.
- Added a separator between the buttons "Decrypt ciphertexts" and "Back
to Key Generation and Encryption" in the attack tabs
References Issue jcryptool#40
Code cleanup

Added @OverRide tags
Added ColorService to manifest.mf

Replaced Color selction with jct default colorService
Changed foreground color and background color
Gave the description more space
grthor pushed a commit that referenced this issue Sep 22, 2018
@grthor grthor removed the Type:Bug label Nov 6, 2018
@grthor grthor added Area:UI+UX-Logic Everything related to SWT / general RCP UI Phase:Backlog Let's get to inbox zero labels Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:UI+UX-Logic Everything related to SWT / general RCP UI Phase:Backlog Let's get to inbox zero Type:New-Feature
Projects
None yet
Development

No branches or pull requests

3 participants