Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow images to be pasted as commands on the terminal #342

Closed
ssv1000 opened this issue Sep 28, 2017 · 6 comments
Closed

Disallow images to be pasted as commands on the terminal #342

ssv1000 opened this issue Sep 28, 2017 · 6 comments

Comments

@ssv1000
Copy link

ssv1000 commented Sep 28, 2017

Images should not be allowed to be pasted on to the terminal

Can paste the images onto the terminal

Open jquery terminal.

    Copy an image to the clipboard
   Go to terminal and do Ctrl+V  -- then image will be pasted on to the terminal

Chrome & Windows-10

@jcubic
Copy link
Owner

jcubic commented Sep 28, 2017

This is a features added on purpose, when you have images in clipboard they can be echo when paste.

Do you think it's a bad idea?

I can make an option to disable that feature.

@ssv1000
Copy link
Author

ssv1000 commented Sep 28, 2017 via email

@jcubic jcubic changed the title Allows images to be pasted as commands on the terminal Disallows images to be pasted as commands on the terminal Sep 28, 2017
@jcubic jcubic changed the title Disallows images to be pasted as commands on the terminal Disallow images to be pasted as commands on the terminal Sep 28, 2017
@ssv1000
Copy link
Author

ssv1000 commented Sep 29, 2017 via email

@jcubic
Copy link
Owner

jcubic commented Sep 29, 2017

Added in devel branch option pasteImage, it will be in next version 1.9.0.

You can grab devel version if you need it now, all build files have VER as version so you will know it's devel version.

@raviteja2200
Copy link

tested this change on devel branch, works as desired.

@ssv1000
Copy link
Author

ssv1000 commented Oct 2, 2017

tested

@ssv1000 ssv1000 closed this as completed Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants