Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize Event not triggered in Firefox #395

Closed
mesurinna opened this issue May 16, 2018 · 2 comments
Closed

Resize Event not triggered in Firefox #395

mesurinna opened this issue May 16, 2018 · 2 comments

Comments

@mesurinna
Copy link

mesurinna commented May 16, 2018

The resizing event is not fired correctly in firefox (code Lines 805-807):

                $(iframe.contentWindow).on('resize', function() {
                    callbacks.fire();
                });

When i resize the window nothing happens, after clicking with mouse with the right button, the view of the terminal is refreshed.

This happens only in Firefox. IE is resizing correctly, and Chrome is using the resizeObserver, as expected.

Someone else experiencing this error? I am running the Terminal in a Iframe, maybe that is the cause of my error?

Kind regards
Tommaso

jcubic added a commit that referenced this issue May 16, 2018
@jcubic
Copy link
Owner

jcubic commented May 16, 2018

The fix is in devel branch, it will be in next version. To fix this now you can use this css snipped:

.terminal > .resizer, .terminal > .font .resizer {
    visibility: visible;
    pointer-events: none;
}

@mesurinna
Copy link
Author

Thanks for the fix.

Kind regards
Tommaso

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants