Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with echo blank lines #411

Closed
jcubic opened this issue Jul 19, 2018 · 2 comments
Closed

Issue with echo blank lines #411

jcubic opened this issue Jul 19, 2018 · 2 comments

Comments

@jcubic
Copy link
Owner

jcubic commented Jul 19, 2018

There is inconsistency:

term.echo('\n');

prints 2 blank lines, the same as this:

term.echo('\n\n');

but:

term.echo('');

prints nothing

@jcubic
Copy link
Owner Author

jcubic commented Jul 19, 2018

Something to consider should extended commands after remove print the line? term.echo("[[ foo ]]").

Maybe just fix less plugin (that was used when founding this issue) to use:

str.replace(/^$/gm, ' ') to don't have blank lines, or maybe make it work in this way if string is empty don't print anything but if not print every line.

@jcubic jcubic changed the title Echo empty string should print blank line Issue with echo blank lines Jul 19, 2018
jcubic added a commit that referenced this issue Jul 19, 2018
@jcubic
Copy link
Owner Author

jcubic commented Jul 21, 2018

released in version 1.19.0

@jcubic jcubic closed this as completed Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant