Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

You can't enter characters that have more then one code point #422

Closed
jcubic opened this issue Aug 23, 2018 · 2 comments
Closed

You can't enter characters that have more then one code point #422

jcubic opened this issue Aug 23, 2018 · 2 comments

Comments

@jcubic
Copy link
Owner

jcubic commented Aug 23, 2018 •
edited
Loading

Expected behavior

it should render 8⃣ (8️⃣)

Actual behavior

it render 3 spans 8 empty span and 0 width rectangle

Steps to reproduce

Enter this in console '\u0038\uFE0F\u20E3' and copy paste result 8️⃣ into terminal
@jcubic jcubic changed the title You can enter characters that have more then one code point You can't enter characters that have more then one code point Aug 23, 2018
@jcubic
Copy link
Owner Author

jcubic commented Aug 23, 2018

The 8⃣ is emoji that have code points '\u0038\uFE0F\u20E3' and only then renders as emoji (\u20E3 is 0 width box) but normal characters that have 2 codepoints also don't render properly like 💩 renders as �� when inserted into cmd.

jcubic added a commit that referenced this issue Aug 23, 2018
@jcubic
fix emoji and Unicode surrogate pairs #422 + disable save into kill a…
bb2ee76 
…rea and clipbard when holding keys
jcubic added a commit that referenced this issue Aug 25, 2018
@jcubic
actual fix for emoji and unicode surrogate pairs #422
71b24fe
jcubic added a commit that referenced this issue Aug 25, 2018
@jcubic
fix for emoji and unicode surrogate pairs #422
6675f3a
@jcubic
Copy link
Owner Author

jcubic commented Aug 26, 2018

released in version 1.21.0

@jcubic jcubic closed this as completed Aug 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcubic