Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji in .raw is shifted to bottom #461

Closed
jcubic opened this issue Jan 20, 2019 · 2 comments
Closed

Emoji in .raw is shifted to bottom #461

jcubic opened this issue Jan 20, 2019 · 2 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Jan 20, 2019

Expected behavior

Emoji in raw is the same line as text

Actual behavior

Emoji is shifted to bottom

Steps to reproduce

Open https://codepen.io/jcubic/pen/qPVMPg

@jcubic jcubic added the Bug label Jan 20, 2019
@jcubic
Copy link
Owner Author

jcubic commented Jan 20, 2019

The fix is to remove raw class in finalize:

finalize: function(div) {
                      div.removeClass('raw');
                  }

but this also can be change so the js is not needed

@jcubic
Copy link
Owner Author

jcubic commented Jan 20, 2019

It think that it would be better to just disable emoji inside .raw this :not(.raw) in css was removed just so emoji in codepen works and this can be achieved by removing raw class.

jcubic added a commit that referenced this issue Jan 20, 2019
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Jan 20, 2019
@jcubic jcubic closed this as completed Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant