-
-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calling echo with zero arguments prints undefined #467
Comments
I think that it should just do nothing or just throw exception, you're echo nothing, it's definitely users error that should be ignored or user should be notified. I don't think that |
I've decided that this is correct behavior, now if you echo undefined or empty string you will have single blank like. But if empty string left after extended command got removed and executed it will be ignored. |
I forgot to say |
Updated the code it now prints |
Good job (and so quick!), thanks. Cool project, keep it up. |
In version 2.2.0 |
Expected behavior
term.echo();
should result in output of one blank line.Actual behavior
term.echo();
outputs a line with 'undefined'.Steps to reproduce
https://jsfiddle.net/pjn54s6f/1/embedded/js,result
Browser and OS
Any. (Open the jsfiddle result in IE to highlight my issue with using
term.echo('');
).The text was updated successfully, but these errors were encountered: