Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space scroll Terminal in Edge and IE #507

Closed
jcubic opened this issue Jun 23, 2019 · 3 comments
Closed

Space scroll Terminal in Edge and IE #507

jcubic opened this issue Jun 23, 2019 · 3 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Jun 23, 2019

Expected behavior

Pressing space should only insert space

Actual behavior

The page is scrolled down

Steps to reproduce

  1. Open terminal demo https://terminal.jcubic.pl/
  2. Focus terminal
  3. Press space

Browser and OS

Windows IE and Edge

@jcubic jcubic added the Bug label Jun 23, 2019
@jcubic
Copy link
Owner Author

jcubic commented Jun 23, 2019

It seems that also backspace go one page back in history but only in IE, in Edge it work fine.

jcubic added a commit that referenced this issue Jul 28, 2019
@jcubic
Copy link
Owner Author

jcubic commented Jul 28, 2019

the problem was that when calling keypress insert was called that was calling redraw that was using visibility: hidden to make rendering faster. In IE and Edge when textarea was hidden it didn't prevent default behavior of scrolling the page. First try was setTimeout 0 but it didn't work (the solution was good but there was bug in debug code that was later removed when looked at diff).

Maybe there is better way to hide the cmd but don't hide textarea so it don't loose focus. In Chrome textarea keep having focus when cmd is hidden.

@jcubic
Copy link
Owner Author

jcubic commented Jul 28, 2019

TODO: remove current code and add wrapper for prompt and lines, hide the wrapper instead of .cmd.

jcubic added a commit that referenced this issue Jul 31, 2019
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Jul 31, 2019
@jcubic jcubic closed this as completed Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant