Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with emoji #514

Closed
jcubic opened this issue Aug 16, 2019 · 2 comments
Closed

Issues with emoji #514

jcubic opened this issue Aug 16, 2019 · 2 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Aug 16, 2019

Expected behavior

Emoji is correct

Actual behavior

Emoji in demo was cut off, and emoji as unicode is marked as 1ch (it should be 2ch).

The fix for css:

.cmd .emoji, .terminal-output>:not(.raw) .emoji {
    background-size: contain;
    background-repeat: no-repeat;
}

and solution for width, the formatter need to add style attribute.

@jcubic
Copy link
Owner Author

jcubic commented Aug 16, 2019

It's seems that there is only one unicode character with 1ch that I was using, rest the of emoji have 2 characters size.

jcubic added a commit that referenced this issue Aug 17, 2019
@jcubic jcubic added Bug resolved if issue is resolved, it will be open until merge with master labels Aug 17, 2019
jcubic added a commit that referenced this issue Aug 18, 2019
@jcubic
Copy link
Owner Author

jcubic commented Aug 29, 2019

released in 2.8.0

@jcubic jcubic closed this as completed Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant