Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve less and write unit tests #522

Closed
4 tasks done
jcubic opened this issue Sep 9, 2019 · 2 comments
Closed
4 tasks done

Improve less and write unit tests #522

jcubic opened this issue Sep 9, 2019 · 2 comments
Labels
feature resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Sep 9, 2019

Expected behavior

less render text properly

Actual behavior

text is cut by number of columns

Steps to reproduce

Open less with unicode demo https://codepen.io/jcubic/pen/oMYbRG

the problem is this code, added when adding handling of images:

                    var defer = $.Deferred();
                    var parts = text.split(img_split_re).filter(Boolean);
                    var promise = defer.promise();
                    if (parts.length === 1) {
                        defer.resolve(parts);

parts is not lines it should be:

defer.resolve(text.split('\n'));

TODO:

  • Fix Initial issue
  • Write Base Unit Tests
  • Fix onerror issue
  • Unit test for images
@jcubic jcubic added the Bug label Sep 9, 2019
jcubic added a commit that referenced this issue Sep 14, 2019
@jcubic
Copy link
Owner Author

jcubic commented Oct 12, 2019

This is critical because tests for less are broken. (part of tests are disabled and it break build because I've added a check, but after removing disabled tests they fail).

@jcubic
Copy link
Owner Author

jcubic commented Oct 28, 2019

Bug chunk of the less plugin is slicing images, it will be challanging to test this, it will require to mock Canvas and Image.

Fore reference:

TODO: if less don't load image it will break, don't load.

@jcubic jcubic changed the title Less don't render multi line strings Improve less and write unit tests Oct 28, 2019
@jcubic jcubic added feature and removed Bug labels Oct 28, 2019
jcubic added a commit that referenced this issue Oct 28, 2019
jcubic added a commit that referenced this issue Nov 24, 2019
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Nov 24, 2019
jcubic added a commit that referenced this issue Nov 24, 2019
jcubic added a commit that referenced this issue Nov 24, 2019
@jcubic jcubic closed this as completed Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant