-
-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve less and write unit tests #522
Comments
This is critical because tests for less are broken. (part of tests are disabled and it break build because I've added a check, but after removing disabled tests they fail). |
jcubic
added a commit
that referenced
this issue
Oct 13, 2019
jcubic
added a commit
that referenced
this issue
Oct 13, 2019
jcubic
added a commit
that referenced
this issue
Oct 28, 2019
Bug chunk of the less plugin is slicing images, it will be challanging to test this, it will require to mock Canvas and Image. Fore reference: TODO: if less don't load image it will break, don't load. |
jcubic
added a commit
that referenced
this issue
Oct 28, 2019
jcubic
added a commit
that referenced
this issue
Oct 29, 2019
jcubic
added a commit
that referenced
this issue
Nov 24, 2019
jcubic
added a commit
that referenced
this issue
Nov 24, 2019
jcubic
added a commit
that referenced
this issue
Nov 24, 2019
jcubic
added a commit
that referenced
this issue
Nov 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior
less render text properly
Actual behavior
text is cut by number of columns
Steps to reproduce
Open less with unicode demo https://codepen.io/jcubic/pen/oMYbRG
the problem is this code, added when adding handling of images:
parts is not lines it should be:
TODO:
The text was updated successfully, but these errors were encountered: