Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt don't wait for Exec with login data #898

Closed
1 task done
jcubic opened this issue Aug 21, 2023 · 1 comment
Closed
1 task done

Prompt don't wait for Exec with login data #898

jcubic opened this issue Aug 21, 2023 · 1 comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Aug 21, 2023

Issue summary

If you have login and you exec to authenticate, the prompt is not executed after login.
So you can get username from the terminal to display it in the prompt.

Expected behavior

Prompt should be executed after login so I can have username in prompt

Actual behavior

I've got undefined as login name in prompt after login

Steps to reproduce

  1. Open demo https://codepen.io/jcubic/pen/YzROWeM
  2. Instead of login name in prompt there is undefined

Additional notes

This only happen with exec

  • Attempt to create unit test
@jcubic jcubic added the Bug label Aug 21, 2023
jcubic added a commit that referenced this issue Oct 20, 2023
@jcubic
Copy link
Owner Author

jcubic commented Oct 20, 2023

No unit test was created because I was not able to create a falling test in Node.

@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Oct 20, 2023
jcubic added a commit that referenced this issue Oct 20, 2023
@jcubic jcubic closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant