Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jcunni/service cat drilldowns #20

Merged
merged 6 commits into from
Jun 7, 2023
Merged

Conversation

jcunninghame
Copy link
Owner

Drilldowns under service category 1
Some styling and polish

@jcunninghame jcunninghame requested a review from lpanda2 June 6, 2023 19:42
Comment on lines +10 to +14
st.set_page_config(
layout="wide",
page_icon=comp.favicon(),
page_title="Tuva Health - Financial Datastory",
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dude fuck yeah this is awesome

components.py Outdated
@@ -119,18 +120,24 @@ def claim_type_line_chart(df, animated=True):
"grid": {"right": 140},
"series": seriesList,
}
st_echarts(options=option, height="450px", width="640px", key="chart")
st_echarts(options=option, height="550px", key="chart")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

little nit but can we make the height like 525 or something? it's not lining up with the bottom of the metric bans for me

Comment on lines +322 to +323
top_col1, top_col2 = st.columns(2)
bot_col1, bot_col2 = st.columns(2)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hooray for hacks!!

Copy link
Collaborator

@lpanda2 lpanda2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice dude it's really coming together. maybe we should make this the first page? as opposed to the main_page?

@jcunninghame jcunninghame merged commit c384be2 into main Jun 7, 2023
@jcunninghame jcunninghame deleted the jcunni/service-cat-drilldowns branch June 7, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants