Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jcunni/sprucing up #4

Merged
merged 7 commits into from
May 22, 2023
Merged

Jcunni/sprucing up #4

merged 7 commits into from
May 22, 2023

Conversation

jcunninghame
Copy link
Owner

Code cleanup and utilizing the util functions Lipsa added with her last PR. Also some blurbs about data to make things a data story?

@jcunninghame jcunninghame requested a review from lpanda2 May 22, 2023 12:42
Copy link
Collaborator

@lpanda2 lpanda2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!! was thinking about making some changes to the financial page this morning. want to run it by you

st.markdown("""Inpatient and Outpatient spend are the largest drivers of PMPM during this time period""")
plost.bar_chart(data=grouped_pmpm, bar='Metric', value=pmpm_cats, stack='normalize',
direction='horizontal', legend='top', height=200)
st.markdown("### Total Pharmacy Spend Over Claim Period**")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick nit there's a ** at the end of this

plost.bar_chart(data=grouped_pmpm, bar='Metric', value=pmpm_cats, stack='normalize',
direction='horizontal', legend='top', height=200)
st.markdown("### Total Pharmacy Spend Over Claim Period**")
st.markdown("""Pharmacy Spend appears largely steady between 2016 and 2018, averaging between $100k-$200k a month.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$100k-$200k <- try wrapping this in backticks or separating with a space because it's inferring as latex

main_page.py Outdated
Comment on lines 75 to 78
col1, col2, col3 = st.columns([1,1,1])
col1.metric("Total Medical Spend", '${}'.format(util.human_format(total_spend)))
col2.metric("Total Member Months", util.human_format(total_member_months))
col3.metric("Average PMPM", '${}'.format(util.human_format(avg_pmpm)))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome -- I'll copy this into the financial breakdown. Should we add pharmacy spend?

Copy link
Collaborator

@lpanda2 lpanda2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!! was thinking about making some changes to the financial page this morning. want to run it by you

@jcunninghame jcunninghame merged commit bcc3085 into main May 22, 2023
@jcunninghame jcunninghame deleted the jcunni/sprucing-up branch May 22, 2023 13:37
jcunninghame added a commit that referenced this pull request Jun 21, 2023
* initial page with a data table from the google sheet, start reqs.txt for later use

* some manual data cleaning, throw in a line chart with Y axis select

* gitignore and some requirement updates

* snowflake connect, use .env vars

* update SQL query, add in time filter

* some summary metrics

* some page 2 work

* patient demo charts

* some header updates, container sizing, pre-commit req

* more ignoring

* [ADDED] a small util file

* [ADDED] a Financial Summary page

* [ADDED] some basic summary

* [ADDED] my original cost summary

* [FIXED] sort the condition table

* [ADDED] a little visual delighter

* cached data funcs, use util, lowercasing

* blurbs

* cache and func treatment for data, adding some blurbs

* pretty formating

* page rename

* small errs

* pharm spend

* [RENAMED] files and then removed chronic conditions from it

* [ADDED] placeholder for the components

* [ADDED] the following:
- claim type chart breakdown (with pharmacy spend)
- filter by year month for the service category 2
- improve label/axis in chart

* [ADDED] chronic condition charts

* wip

* financial ban work, incorporate

* ban component use, make slider a year filter

* copy condition graph over

* variety

* big stacked horizontal bar

* pharm trend line, remove drilldown page

* config for pre-commit

* the great reformatting

* dep

* moving pharmacy block

* initial readme

* use lipsas database for now

* wip, animation working for altair chart

* echart line w/ animation, some state management

* colors and turn off animation for now

* switch from dotenv to tomli

* custom theme

* [ADDED] test results

* [ADDED] use case

* remove unused deps

* pandas version of snowflake connector

* [ADDED] Pop

* [FIXED] think this slider wasn't working properly?

* move chart into components file, grouped bar for pop comparison

* move data calls to one file

* [REMOVED] charts and unused text

* [BUGFIX] hook claim type pmpm data up to time slider

* [ADDED] a color palette and some styling on the metric cards

* [ADDED] light color and styling to this line chart

* [ADDED] Logo

* [ADDED] chatgpt language

* [FIXED] round the numbers and add the new color formats

* [ADDED] colors and highlighting to the other charts
- also rounded values in the pmpm claim type line chart

* [ADDED] show the table and the chart as tabs

* cluster of drilldowns

* stylizing, make it wide mode

* tab branding

* renaming and organizing pages, adjusting chart heights

* read in data from s3 extracts instead of snowflake

* fix year

* hide some pages we dont want to show, renaming, update deps

* missing dep for deployment

* case sesentive

* hide other pages, add logo to top of financial summary

* [ADDED] threshold for row count

* handle one year of data better

* change from year to quarter

* query updates, point to lds data

* wip

* get provider grouping working again

* comment out cost summary because not possible on their source data
right now

* copy updates

* chart height

---------

Co-authored-by: Lipsa Panda <lpanda2014@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants