Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hxgen: does the generator need to do anything to support @include directives ? #25

Closed
jcward opened this issue Jul 15, 2018 · 1 comment
Closed

hxgen: does the generator need to do anything to support @include directives ? #25

jcward opened this issue Jul 15, 2018 · 1 comment

Comments

@jcward
Copy link
Owner

jcward commented Jul 15, 2018

...or are they mostly a runtime concern?

In any case, write some tests on them.
@jcward
Copy link
Owner Author

jcward commented Jul 23, 2018

I think it should verify that the query provides the arguments.

WRT parameters in fragments -- search for this is what GraphQL today does -- I believe it should also verify that, for any parameter usage in a fragment, the top-level query must provide all referenced params.

jcward added a commit that referenced this issue Jul 23, 2018
@jcward
Fix issue #25 -- validate the parameters/args used in directives agai…
f929e48 
…nst the variables defined in the operation (and tests)
@jcward jcward closed this as completed Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcward