fix: Optimize state updates and explicitly add ON_OFF feature support for HVACMode.OFF entities #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves a warning related to entities implementing HVACMode.OFF without explicitly declaring the ClimateEntityFeature.ON_OFF feature. Fixes #76
sayam93
changed the title
Code optimisation to only update the state when there's an actual change in the entity's attributes, reducing redundant state writes.
sayam93
changed the title
sayam93
changed the title
This was referenced Dec 11, 2024
implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature
#76
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code optimisation to only update the state when there's an actual change in the entity's attributes, reducing redundant state writes. Before this, it was possible for the climate entities to not restore state properly on Home Assistant restarts
This also resolves a warning in Home Assistant related to entities that implement HVACMode.OFF but do not explicitly declare the ClimateEntityFeature.ON_OFF feature. It ensures compatibility across different Home Assistant versions by dynamically adding the ON_OFF feature when applicable or defining a custom fallback.