Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting disabling of hashid signing #30

Closed
olliebennett opened this issue Jun 13, 2017 · 0 comments · Fixed by #37
Closed

Supporting disabling of hashid signing #30

olliebennett opened this issue Jun 13, 2017 · 0 comments · Fixed by #37

Comments

@olliebennett
Copy link
Contributor

olliebennett commented Jun 13, 2017

I am attempting to migrate a production app from v0.7.0 to v1.0.0.

The improvements in 1.0.0 seem very worthwhile and well thought out, and address various other problems - thanks!

The "hashid signing" feature that this gem has implemented (see issue and PR) is causing a totally new set of hashids to be generated.

Would you consider a disable_hashid_signing config option? I appreciate that v 1.0 is not backward-compatible with 0.x but without this option, it seems there is no way to migrate at all?

Another reason to support disabling this feature is that - although useful, and good to enable by default - it's a totally arbitrary solution for the problem, and it prevents compatibility with other hashid tools which would not be encoding using the [HASHID_TOKEN, id] format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant