Support disabling of hashid signing feature #37
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #30 by implementing a configuration option,
sign_hashids
, which controls how the underlying hashid is generated. The choice is:sign_hashids = true (default)
encode_id([42, id])
.[42, x]
and return thex
.sign_hashids = false
encode_id(id)
.hashid-rails < 1.0.0
; in order to maintain backwards compatibility for existing hashids, this must be set.