Disable find method with a configuration option. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@taranda Thanks for putting this together! The code looks good to me. Once the Codacy style issues are corrected, I'd be happy to merge it in. |
jcypret
reviewed
Feb 12, 2017
lib/hashid/rails.rb
Outdated
| @@ -63,7 +63,9 @@ def decode_id(ids) | |||
| end | |||
|
|
|||
| def find(hashid) | |||
| model_reload? ? super(hashid) : super(decode_id(hashid) || hashid) | |||
| (model_reload? || Hashid::Rails.configuration.disable_find) ? | |||
There was a problem hiding this comment.
Just switching this to a regular if/else would be good 👍
README.md
Outdated
| in some cases, and as an id in others. This unpredictably is usually not desired and can lead to subtle bugs appearing at runtime | ||
|
|
||
| In order to avoid this problem, users can add `config.disable_find = true` to their initializer. This will disable the hashid | ||
| functionality of the `find` method and force `find` to only accpet normal (unhashed) ids. Under this configuration, programmers |
spec/hashid/rails_spec.rb
Outdated
| end | ||
| # 100024 was selected because it unhashes to 187412 | ||
| model = FakeModel.create! | ||
| model.update(id: 100_024) |
There was a problem hiding this comment.
Could I suggest update! instead, so this fails loudly if the model can't be updated?
|
Nice one; this seems like a great solution to avoid excessive use of |
|
Thanks for the feedback ollie. Update pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in issue 21, when using alphabets that contain numerals, a valid hashid could be identical to a valid id. This can cause the
findmethod to behave unpredictable and lead to subtle bugs at runtime.This pull request adds a configuration option,
config.disable_findwhich will disable the hashid feature of thefindmethod forcingfindto behave in its default manner and to not accept hashids. All arguments passed tofindwill be assumed to be normal ids and will not be unhashed.This pull request should resolve issue 21.