Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace local prettier plugin with npm package #3197

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

Alex-huxiyang
Copy link
Collaborator

@Alex-huxiyang Alex-huxiyang commented Sep 20, 2024

这个 PR 做了什么? (简要描述所做更改)

这个 PR 是什么类型? (至少选择一个)

  • feat: 新特性提交
  • fix: bug 修复
  • docs: 文档改进
  • style: 组件样式/交互改进
  • type: 类型定义更新
  • perf: 性能、包体积优化
  • refactor: 代码重构、代码风格优化
  • test: 测试用例
  • chore(deps): 依赖升级
  • chore(demo): 演示代码改进
  • chore(locale): 国际化改进
  • chore: 其他改动(是关于什么的改动?)

这个 PR 涉及以下平台:

  • NutUI H5 @nutui/nutui
  • NutUI Taro @nutui/nutui-taro

这个 PR 是否已自测:

Summary by CodeRabbit

  • 新功能

    • 更新了Markdown表格的格式化插件,以提高Markdown内容的处理能力。
  • 依赖项更新

    • 移除了@nutui/prettier-plugin依赖,新增了prettier-markdown-table依赖。

Copy link

coderabbitai bot commented Sep 20, 2024

Walkthrough

此次更改涉及对 Prettier 配置和相关依赖的更新。具体而言,.prettierrc 文件中的插件被替换为 prettier-markdown-table,同时在 package.json 文件中移除了 @nutui/prettier-plugin 依赖,并添加了 prettier-markdown-table 作为新依赖。此外,@nutui/prettier-plugin 包的相关文件被删除,表明该插件的功能不再使用。

Changes

文件路径 更改摘要
.prettierrc 插件更新:"@nutui/prettier-plugin" 替换为 "prettier-markdown-table"
package.json 依赖移除:"@nutui/prettier-plugin": "workspace:*";依赖添加:"prettier-markdown-table": "^1.0.1"
packages/nutui-prettier-plugin/* 删除了 index.jspackage.json 文件,移除相关功能和配置

Possibly related PRs

  • chore(deps): update #3120: 此 PR 更新了 packages/nutui-prettier-plugin/package.json 中的 prettier 依赖,与主 PR 中的 Prettier 插件配置更改直接相关。

🐰 在草地上跳跃,欢庆新变化,
插件更新,格式更佳,
Markdown 表格,整齐如画,
兔子们欢呼,乐在其中,
代码清新,未来可期! 🌼


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c0f0fc0 and 09ca075.

Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing (4)
  • .prettierrc (1 hunks)
  • package.json (1 hunks)
  • packages/nutui-prettier-plugin/index.js (0 hunks)
  • packages/nutui-prettier-plugin/package.json (0 hunks)
Files not reviewed due to no reviewable changes (2)
  • packages/nutui-prettier-plugin/index.js
  • packages/nutui-prettier-plugin/package.json
Additional comments not posted (2)
.prettierrc (1)

11-11: 更改看起来不错!

将本地 Prettier 插件替换为 npm 包 prettier-markdown-table 有助于简化格式化过程。

请运行以下脚本来验证现有 Markdown 表格的格式是否符合新插件的预期:

package.json (1)

108-108: 依赖项移除正确

移除本地的 Prettier 插件 @nutui/prettier-plugin,转而使用标准的 npm 包,这有助于提高可维护性和一致性。这一改动与 PR 的目标相符。


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.18%. Comparing base (c0f0fc0) to head (09ca075).
Report is 1 commits behind head on v4.

Additional details and impacted files
@@           Coverage Diff           @@
##               v4    #3197   +/-   ##
=======================================
  Coverage   81.18%   81.18%           
=======================================
  Files         226      226           
  Lines       18142    18142           
  Branches     2485     2485           
=======================================
  Hits        14729    14729           
  Misses       3395     3395           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alex-huxiyang Alex-huxiyang merged commit 96e8c46 into v4 Sep 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant