-
-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Trio out-of-the-box #295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think we should cover both. Just add a new tox scenario with and without trio :)
@jd How's this look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good though I'd prefer to have py39-trio
rather than notrio
😁
Fair enough! |
This PR makes `@retry` just work when running under Trio.
Made that change and also rebased on latest master, to make mergify happy |
- run: | ||
command: | | ||
sudo pip install tox | ||
tox -e py39-notrio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inconsistent with tox.int
(py39-trio
for trio
and normal python versions for other)
Hello @njsmith ! I understand it has been over 2 years since this PR was opened. Might there be any chance of a follow-up to support trio out of the box? I think this feature is great, as it can be easy to forget add |
I also wonder how to use tenacity with trio. If I use tenacity.retry() as a decorator for a async function, how can I check the result of the async function via Even if I change my retry condition to Please give me some tips, thank you guys~~~ |
This can be closed, as it was implemented with #463 |
This PR makes
@retry
just work when running under Trio.For now, I added
trio
to the test deps in tox.ini, so we can testit. The code is also designed to handle things gracefully if trio
isn't installed, but currently there's not any automated test for
that... how would you like to handle this? Maybe add another
test environment without trio?