Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong cookie domain set when redirected #11

Closed
maccyber opened this issue Nov 30, 2022 · 0 comments
Closed

Wrong cookie domain set when redirected #11

maccyber opened this issue Nov 30, 2022 · 0 comments

Comments

@maccyber
Copy link
Contributor

maccyber commented Nov 30, 2022

  1. fetch("https://first.url")
  2. https://first.url 302 redirect to https://second.url
  3. https://second.url returns cookies
  4. cookies are set to the wrong domain: https://first.url (cookieJar.getCookies({ domain: "second.url" }) is empty)

cookieJar.setCookie(value, input);

Should maybe be:

cookieJar.setCookie(value, result.url);
@jd1378 jd1378 closed this as completed in 86d2ad0 Nov 30, 2022
jd1378 added a commit that referenced this issue Nov 30, 2022
…ected

Sets the correct cookie domain when redirected. Fixes #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant