Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace impl that triggered a lint on Rust 1.80 #171

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

jdahlstrom
Copy link
Owner

@jdahlstrom jdahlstrom commented Aug 5, 2024

The generic Mul for Scalar impl violated orphan rules, but used to
be accepted by rustc due to a bug. Replace the impl with separate concrete
impls for f32, i32, and u32.

See rust-lang/rust#124559 for more info.

@jdahlstrom jdahlstrom merged commit 454c1a2 into dev Aug 6, 2024
1 check passed
@jdahlstrom jdahlstrom deleted the fix-orphan-lint branch August 7, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant